feat(DynamicVoiceChat): implement main logic #1370
Conversation
Co-authored-by: Suraj Kumar <[email protected]> Signed-off-by: Chris Sdogkos <[email protected]>
Using 'Logger#info' is too spammy in the console, use 'Logger#trace' instead. Signed-off-by: Chris Sdogkos <[email protected]>
Signed-off-by: Chris Sdogkos <[email protected]>
Signed-off-by: Chris Sdogkos <[email protected]>
christolis
added
config-changes
tj-wazei
left a comment
tj-wazei
left a comment
There was a problem hiding this comment.
Happy with this and have tested.
| channel.delete() | ||
| .queue(_ -> logger.trace("Deleted dynamically created voice channel: {} ", | ||
| channel.getName()), | ||
| error -> logger.error("Failed to delete dynamically created voice channel: {} ", | ||
| channel.getName(), error)); | ||
| } |
There was a problem hiding this comment.
I think I would kinda prefer if this workflow will post a warning in the voice channel chat with a specific timer for deletion (30sec) or whatever, then checking again for memberCount == 0 and then actually deleting or otherwise stopping the workflow
There was a problem hiding this comment.
I thought about this when reviewing and decided to skip past a timer. There is a message sent when the channel is created and there's really no need to keep the channel longer. It can be recreated right away anyway.
Having said this, I am now thinking about moderation...
Temp voice chat -> users posting nonsense -> evidence deleted ...?
Perhaps instead of deleting the channel, we can move it to a private/mod-only voice-chat-archive channel so only we can still check chats. Followed by a daily clean up task.
What do you think?
There was a problem hiding this comment.
That sounds great, we need to keep track of what people post in these ephemeral channels. Perhaps instead of deleting, send a log of all the messages sent as one embed.
There was a problem hiding this comment.
You'll hit the character limit very quickly with an embed. It's best to just hide the channel so only moderators can see this and clean up after some time period.
|
Would love to carry this feature forward, got permission from @christolis |
|
Just some things to note: "Support/Studying Room" with no numbers produces the desired result of TJ creating a temp channel for the user and deleting it when everyone leaves the channel. "Support/Studying Room" with any number after it (1,2,3,4) does not produce a temp channel, and the channel itself it deleted after everyone leaves the channel. This brings me to the question of when this gets implemented, will we have only one channel, "Support/Studying Room", with no numbers? If so, this does not need to be addressed. If there will still be 4 different studying channels as it is currently, this is something that will need to be handled. Just wanted to confirm before tackling that, since it's not really an issue per se if the channel is just "Support/Studying Room" with no numbers |
4 participants
Closes #1113.
Showcase
Screen.Recording.2026-01-04.at.02.35.21.mov
Configuration changes
dynamicVoiceChannelPatterns